Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-11 Thread Rusty Russell
Ohad Ben-Cohen writes: > On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin wrote: >> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote: >>> virtio spec requires that all drivers set DRIVER_OK >>> before using devices. While rpmsg isn't yet >>> included in the virtio 1 spec, pre

Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-11 Thread Ohad Ben-Cohen
On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin wrote: > On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote: >> virtio spec requires that all drivers set DRIVER_OK >> before using devices. While rpmsg isn't yet >> included in the virtio 1 spec, previous spec versions >> also re

Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-09 Thread Michael S. Tsirkin
On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote: > virtio spec requires that all drivers set DRIVER_OK > before using devices. While rpmsg isn't yet > included in the virtio 1 spec, previous spec versions > also required this. > > virtio rpmsg violates this rule: is calls kick >

Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2015 at 05:39:20PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > virtio spec requires that all drivers set DRIVER_OK > > before using devices. While rpmsg isn't yet > > included in the virtio 1 spec, previous spec versions > > also required this. > > > > virtio rpm

Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-09 Thread Rusty Russell
"Michael S. Tsirkin" writes: > virtio spec requires that all drivers set DRIVER_OK > before using devices. While rpmsg isn't yet > included in the virtio 1 spec, previous spec versions > also required this. > > virtio rpmsg violates this rule: is calls kick > before setting DRIVER_OK. > > The fix

[Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-07 Thread Michael S. Tsirkin
virtio spec requires that all drivers set DRIVER_OK before using devices. While rpmsg isn't yet included in the virtio 1 spec, previous spec versions also required this. virtio rpmsg violates this rule: is calls kick before setting DRIVER_OK. The fix isn't trivial since simply calling virtio_devi