Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-27 Thread Markus Armbruster
Anthony PERARD writes: > On Tue, Mar 26, 2019 at 06:48:54PM +0100, Markus Armbruster wrote: >> Known dependencies: >> >> * migration object_init() must run before configure_blockdev(), so block >> backends can register migration blockers >> >> * configure_blockdev() must run before machine_se

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-27 Thread Anthony PERARD
On Tue, Mar 26, 2019 at 06:48:54PM +0100, Markus Armbruster wrote: > Known dependencies: > > * migration object_init() must run before configure_blockdev(), so block > backends can register migration blockers > > * configure_blockdev() must run before machine_set_property(), so > machine prop

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-26 Thread Markus Armbruster
Anthony PERARD writes: > On Tue, Mar 26, 2019 at 03:58:52PM +, Anthony PERARD wrote: >> On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote: >> > Recent commit cda4aa9a5a0 moved block backend creation before machine >> > property evaluation. This broke qemu-iotests 055. Turns

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-26 Thread Anthony PERARD
On Tue, Mar 26, 2019 at 03:58:52PM +, Anthony PERARD wrote: > On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote: > > Recent commit cda4aa9a5a0 moved block backend creation before machine > > property evaluation. This broke qemu-iotests 055. Turns out we need > > to create the

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-26 Thread Anthony PERARD
On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote: > Recent commit cda4aa9a5a0 moved block backend creation before machine > property evaluation. This broke qemu-iotests 055. Turns out we need > to create the migration object before block backends, so block > backends can add migr

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-18 Thread Kevin Wolf
Am 13.03.2019 um 09:43 hat Markus Armbruster geschrieben: > Recent commit cda4aa9a5a0 moved block backend creation before machine > property evaluation. This broke qemu-iotests 055. Turns out we need > to create the migration object before block backends, so block > backends can add migration blo

[Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-13 Thread Markus Armbruster
Recent commit cda4aa9a5a0 moved block backend creation before machine property evaluation. This broke qemu-iotests 055. Turns out we need to create the migration object before block backends, so block backends can add migration blockers. Fix by calling migration_object_init() earlier, right befo

[Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-13 Thread Markus Armbruster
Recent commit cda4aa9a5a0 moved block backend creation before machine property evaluation. This broke qemu-iotests 055. Turns out we need to create the migration object before block backends, so block backends can add migration blockers. Fix by calling migration_object_init() earlier, right befo

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-13 Thread Markus Armbruster
Butterfingers... Please use Message-Id: <20190313084330.16015-1-arm...@redhat.com> and ignore this one.