Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Corey Minyard
On 03/15/2016 09:58 AM, Michael S. Tsirkin wrote: On Tue, Mar 15, 2016 at 03:54:36PM +0100, Paolo Bonzini wrote: On 15/03/2016 15:25, Michael S. Tsirkin wrote: Do you look at all warnings all your software prints? Yes. I also try to understand them, and if they seem useless I propose a patch

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 04:03:23PM +0100, Gerd Hoffmann wrote: > On Di, 2016-03-15 at 16:54 +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 15, 2016 at 03:46:35PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > I think we have already gone through this discussion. > > > > > > > > So now

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Gerd Hoffmann
On Di, 2016-03-15 at 16:54 +0200, Michael S. Tsirkin wrote: > On Tue, Mar 15, 2016 at 03:46:35PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > I think we have already gone through this discussion. > > > > > > So now Corey basically is prevented from sorting sanely > > > because command line m

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 03:54:36PM +0100, Paolo Bonzini wrote: > > > On 15/03/2016 15:25, Michael S. Tsirkin wrote: > > Do you look at all warnings all your software prints? > > Yes. I also try to understand them, and if they seem useless I propose > a patch upstream. > > > What if user uses s

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Paolo Bonzini
On 15/03/2016 15:25, Michael S. Tsirkin wrote: > Do you look at all warnings all your software prints? Yes. I also try to understand them, and if they seem useless I propose a patch upstream. > What if user uses some tool to build the command line? > > consider mem-path - for years we printed

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 03:46:35PM +0100, Gerd Hoffmann wrote: > Hi, > > > > I think we have already gone through this discussion. > > > > So now Corey basically is prevented from sorting sanely > > because command line might not start with opt/ > > Hmm? There are no guarantees whatsoever if

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Gerd Hoffmann
Hi, > > I think we have already gone through this discussion. > > So now Corey basically is prevented from sorting sanely > because command line might not start with opt/ Hmm? There are no guarantees whatsoever if the user used the command line for entries outside /opt. Beside that the "sort

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 03:25:01PM +0100, Gerd Hoffmann wrote: > On Di, 2016-03-15 at 15:14 +0100, Paolo Bonzini wrote: > > > > On 15/03/2016 14:55, Michael S. Tsirkin wrote: > > > Allowing arbitary file names on command line is setting us up for > > > failure: future guests will look for a specif

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 03:14:21PM +0100, Paolo Bonzini wrote: > > > On 15/03/2016 14:55, Michael S. Tsirkin wrote: > > Allowing arbitary file names on command line is setting us up for > > failure: future guests will look for a specific QEMU-specified name and > > will get confused finding a use

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Gerd Hoffmann
On Di, 2016-03-15 at 15:14 +0100, Paolo Bonzini wrote: > > On 15/03/2016 14:55, Michael S. Tsirkin wrote: > > Allowing arbitary file names on command line is setting us up for > > failure: future guests will look for a specific QEMU-specified name and > > will get confused finding a user file ther

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Paolo Bonzini
On 15/03/2016 14:55, Michael S. Tsirkin wrote: > Allowing arbitary file names on command line is setting us up for > failure: future guests will look for a specific QEMU-specified name and > will get confused finding a user file there. > > Signed-off-by: Michael S. Tsirkin Too bad for the user

[Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-15 Thread Michael S. Tsirkin
Allowing arbitary file names on command line is setting us up for failure: future guests will look for a specific QEMU-specified name and will get confused finding a user file there. Signed-off-by: Michael S. Tsirkin --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index