Re: [Qemu-devel] [PATCH] vl.c: move if (fd 0) into if (fd = STDERR_FILENO)

2013-12-29 Thread Chen Gang
Firstly, thank you very much for your reply, this is my first patch for qemu. Next year (2014), as a volunteer, I will try to make a patch for qemu in each month. :-) On 12/29/2013 07:43 AM, Peter Maydell wrote: On 28 December 2013 08:52, Chen Gang gang.chen.5...@gmail.com wrote: For valid

[Qemu-devel] [PATCH] vl.c: move if (fd 0) into if (fd = STDERR_FILENO)

2013-12-28 Thread Chen Gang
For valid 'fd' (in most cases), it is enough to only check whether it is larger than STDERR_FILENO, so recommend to move if (fd 0) into failure processing block. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- vl.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] vl.c: move if (fd 0) into if (fd = STDERR_FILENO)

2013-12-28 Thread Peter Maydell
On 28 December 2013 08:52, Chen Gang gang.chen.5...@gmail.com wrote: For valid 'fd' (in most cases), it is enough to only check whether it is larger than STDERR_FILENO, so recommend to move if (fd 0) into failure processing block. @@ -1064,15 +1064,10 @@ static int parse_add_fd(QemuOpts