Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Chen Gang
On 03/31/2014 09:33 PM, Peter Maydell wrote: > On 31 March 2014 14:26, Chen Gang wrote: >> Next, when I send trivial patches, I will only send to qemu-trivial (not >> send/cc to qemu-devel again), that will be more efficient. :-) > > No, please always send to qemu-devel; just also cc qemu-triv

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Peter Maydell
On 31 March 2014 14:26, Chen Gang wrote: > Next, when I send trivial patches, I will only send to qemu-trivial (not > send/cc to qemu-devel again), that will be more efficient. :-) No, please always send to qemu-devel; just also cc qemu-trivial (or the relevant subsystem maintainers as listed in

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Chen Gang
On 03/31/2014 09:16 PM, Peter Maydell wrote: > On 31 March 2014 14:12, Chen Gang wrote: >> Next, when I send trivial patches, I will/should cc to qemu-trivial. I >> guess, most of my future patches will be trivial patches (and for me, >> trivial != minor). > > We describe on the wiki what we me

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Peter Maydell
On 31 March 2014 14:12, Chen Gang wrote: > Next, when I send trivial patches, I will/should cc to qemu-trivial. I > guess, most of my future patches will be trivial patches (and for me, > trivial != minor). We describe on the wiki what we mean by 'trivial': http://wiki.qemu.org/Contribute/Trivial

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Chen Gang
On 03/31/2014 09:01 PM, Peter Maydell wrote: > On 31 March 2014 13:53, Chen Gang wrote: >> On 03/31/2014 08:38 PM, Markus Armbruster wrote: >>> Chen Gang writes: >>> Hello Maintainers: If it is necessary to send patch v2 by me, please let me know, I will/should send. >>> >>>

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Peter Maydell
On 31 March 2014 13:53, Chen Gang wrote: > On 03/31/2014 08:38 PM, Markus Armbruster wrote: >> Chen Gang writes: >> >>> Hello Maintainers: >>> >>> If it is necessary to send patch v2 by me, please let me know, I >>> will/should send. >> >> Not a maintainer, but if you send a v2 with an improved c

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Chen Gang
On 03/31/2014 08:38 PM, Markus Armbruster wrote: > Chen Gang writes: > >> Hello Maintainers: >> >> If it is necessary to send patch v2 by me, please let me know, I >> will/should send. > > Not a maintainer, but if you send a v2 with an improved commit message, > I'll R-by it, which can only help

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-31 Thread Markus Armbruster
Chen Gang writes: > Hello Maintainers: > > If it is necessary to send patch v2 by me, please let me know, I > will/should send. Not a maintainer, but if you send a v2 with an improved commit message, I'll R-by it, which can only help getting it merged.

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-30 Thread Chen Gang
Hello Maintainers: If it is necessary to send patch v2 by me, please let me know, I will/should send. Thanks. On 03/27/2014 06:01 PM, Chen Gang wrote: > > > On 03/27/2014 04:59 PM, Markus Armbruster wrote: >> Chen Gang writes: >> >>> At present, each 'opt_name' of 'accel_list' is uniq with e

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-27 Thread Chen Gang
On 03/27/2014 04:59 PM, Markus Armbruster wrote: > Chen Gang writes: > >> At present, each 'opt_name' of 'accel_list' is uniq with each other, so >> 'buf' can only match one 'opt_name'. >> >> When drop into the matching code block, can 'break' outside related >> 'for' looping after finish proce

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-27 Thread Chen Gang
On 03/27/2014 03:55 PM, Marcel Apfelbaum wrote: > On Thu, 2014-03-27 at 09:16 +0800, Chen Gang wrote: >> At present, each 'opt_name' of 'accel_list' is uniq with each other, so >> 'buf' can only match one 'opt_name'. >> >> When drop into the matching code block, can 'break' outside related >> 'for'

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-27 Thread Markus Armbruster
Chen Gang writes: > At present, each 'opt_name' of 'accel_list' is uniq with each other, so > 'buf' can only match one 'opt_name'. > > When drop into the matching code block, can 'break' outside related > 'for' looping after finish processing it (just like the other 'break' > within the matching

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-27 Thread Marcel Apfelbaum
On Thu, 2014-03-27 at 09:16 +0800, Chen Gang wrote: > At present, each 'opt_name' of 'accel_list' is uniq with each other, so > 'buf' can only match one 'opt_name'. > > When drop into the matching code block, can 'break' outside related > 'for' looping after finish processing it (just like the oth

[Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-26 Thread Chen Gang
At present, each 'opt_name' of 'accel_list' is uniq with each other, so 'buf' can only match one 'opt_name'. When drop into the matching code block, can 'break' outside related 'for' looping after finish processing it (just like the other 'break' within the matching block). After print "... not s