Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-18 Thread Laurent Vivier
Le 18/12/2017 à 13:30, Peter Maydell a écrit : > On 18 December 2017 at 07:52, Laurent Vivier wrote: >> I think we don't need it anymore as there is no difference betweent >> qemu_main() and main(). > > You need to be a bit cautious there to avoid breaking > the OSX code in ui/cocoa.m, which has

Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-18 Thread Peter Maydell
On 18 December 2017 at 07:52, Laurent Vivier wrote: > I think we don't need it anymore as there is no difference betweent > qemu_main() and main(). You need to be a bit cautious there to avoid breaking the OSX code in ui/cocoa.m, which has its own version of main() which kicks off the GUI code an

Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-17 Thread Laurent Vivier
Le 18/12/2017 à 07:07, Yoni Bettan a écrit : > > > On 11/21/2017 09:30 AM, Laurent Vivier wrote: >> Le 21/11/2017 à 07:41, Yoni Bettan a écrit : >>> * it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800 >>>    when introduced cache-utils.[ch] >>> * since then c

Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-17 Thread Yoni Bettan
On 11/21/2017 09:30 AM, Laurent Vivier wrote: Le 21/11/2017 à 07:41, Yoni Bettan a écrit : * it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800 when introduced cache-utils.[ch] * since then cache-utils.[ch] were removed but **envp was left beh

Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-11-20 Thread Laurent Vivier
Le 21/11/2017 à 07:41, Yoni Bettan a écrit : > * it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800 > when introduced cache-utils.[ch] > * since then cache-utils.[ch] were removed but **envp was left > behind > > Signed-off-by: Yoni Bettan > --- > l

Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-11-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments Type: series Message-id: 20171121064106.13721-1-ybet...@redhat.com === TEST SCRIPT BEGIN ==

[Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-11-20 Thread Yoni Bettan
* it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800 when introduced cache-utils.[ch] * since then cache-utils.[ch] were removed but **envp was left behind Signed-off-by: Yoni Bettan --- linux-user/main.c | 2 +- vl.c | 6 +++--- 2 file