Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Peter Maydell
On 17 September 2014 04:24, Gerd Hoffmann wrote: >> Which brings us to the other half of this: what does our >> UI layer specify should be the behaviour for key repeat? >> Gerd, can you clarify what the common input layer's expectation >> is here? Should UI front ends call qemu_input_event_send_ke

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Gerd Hoffmann
Hi, > Which brings us to the other half of this: what does our > UI layer specify should be the behaviour for key repeat? > Gerd, can you clarify what the common input layer's expectation > is here? Should UI front ends call qemu_input_event_send_key() > with 'down/down/down/up' or 'down/up/down

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Markus Armbruster
Peter Maydell writes: > On 17 September 2014 00:04, Markus Armbruster wrote: >> Anthony Liguori writes: >>> You should fix TigerVNC. It's broken if it isn't sending repeat events. >> >> It *is* sending repeat events. The commit message says so, and I >> tested it to confirm. > > The question

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Peter Maydell
On 17 September 2014 00:04, Markus Armbruster wrote: > Anthony Liguori writes: >> You should fix TigerVNC. It's broken if it isn't sending repeat events. > > It *is* sending repeat events. The commit message says so, and I > tested it to confirm. The question of course is what "repeat events"

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Markus Armbruster
Anthony Liguori writes: > On Tue, Sep 9, 2014 at 8:31 PM, Chun Yan Liu wrote: >> >> > On 9/10/2014 at 02:23 AM, in message > <87tx4girg6@blackfin.pond.sub.org>, >> Markus Armbruster wrote: >>> "Chun Yan Liu" writes: >>> >>> On 9/6/2014 at 05:23 AM, in message >>> > , Stefano >>

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-09 Thread Chun Yan Liu
>>> On 9/10/2014 at 11:47 AM, in message , Anthony Liguori wrote: > On Tue, Sep 9, 2014 at 8:31 PM, Chun Yan Liu wrote: > > > > > On 9/10/2014 at 02:23 AM, in message > <87tx4girg6@blackfin.pond.sub.org>, > > Markus Armbruster wrote: > >> "Chun Yan Liu" writes: > >> > >

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-09 Thread Anthony Liguori
On Tue, Sep 9, 2014 at 8:31 PM, Chun Yan Liu wrote: > > On 9/10/2014 at 02:23 AM, in message <87tx4girg6@blackfin.pond.sub.org>, > Markus Armbruster wrote: >> "Chun Yan Liu" writes: >> >> On 9/6/2014 at 05:23 AM, in message >> > , Stefano >> > Stabellini wrote: >> >> On Fri,

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-09 Thread Chun Yan Liu
>>> On 9/10/2014 at 02:23 AM, in message <87tx4girg6@blackfin.pond.sub.org>, Markus Armbruster wrote: > "Chun Yan Liu" writes: > > On 9/6/2014 at 05:23 AM, in message > > , Stefano > > Stabellini wrote: > >> On Fri, 5 Sep 2014, Chunyan Liu wrote: > >> > Using xen tools 'xl vn

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-09 Thread Markus Armbruster
"Chun Yan Liu" writes: On 9/6/2014 at 05:23 AM, in message > , Stefano > Stabellini wrote: >> On Fri, 5 Sep 2014, Chunyan Liu wrote: >> > Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12), >> > found that: the display of the guest is unexpected while keep >> > pressing a

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-08 Thread Chun Yan Liu
>>> On 9/6/2014 at 05:23 AM, in message , Stefano Stabellini wrote: > On Fri, 5 Sep 2014, Chunyan Liu wrote: > > Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12), > > found that: the display of the guest is unexpected while keep > > pressing a key. We expect the same characte

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2014, Chunyan Liu wrote: > Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12), > found that: the display of the guest is unexpected while keep > pressing a key. We expect the same character multiple times, but > it prints only one time. This happens on a PV guest in text

[Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-04 Thread Chunyan Liu
Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12), found that: the display of the guest is unexpected while keep pressing a key. We expect the same character multiple times, but it prints only one time. This happens on a PV guest in text mode. After debugging, found that tigervnc se