Re: [Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Gerd Hoffmann
On Di, 2016-01-12 at 13:52 +0100, Wolfgang Bumiller wrote: > This pointer should be cleared in vnc_display_close() > otherwise a use-after-free can happen when when using the > old style 'x509' and 'tls' options rather than a persistent > tls-creds -object, by issuing monitor commands to change > t

Re: [Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Wolfgang Bumiller
Ah I forgot to --signoff, sorry > On January 12, 2016 at 1:52 PM Wolfgang Bumiller > wrote: > > > This pointer should be cleared in vnc_display_close() > otherwise a use-after-free can happen when when using the > old style 'x509' and 'tls' options rather than a persistent > tls-creds -object,

Re: [Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Daniel P. Berrange
On Tue, Jan 12, 2016 at 01:52:39PM +0100, Wolfgang Bumiller wrote: > This pointer should be cleared in vnc_display_close() > otherwise a use-after-free can happen when when using the > old style 'x509' and 'tls' options rather than a persistent > tls-creds -object, by issuing monitor commands to ch

[Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Wolfgang Bumiller
This pointer should be cleared in vnc_display_close() otherwise a use-after-free can happen when when using the old style 'x509' and 'tls' options rather than a persistent tls-creds -object, by issuing monitor commands to change the vnc server like so: Start with: -vnc unix:test.socket,x509,tls Th