Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-09-17 Thread Li Qiang
Gerd Hoffmann 于2019年9月17日周二 下午7:45写道: > On Sat, Aug 31, 2019 at 08:39:22AM -0700, Li Qiang wrote: > > Currently when qemu receives a vnc connect, it creates a 'VncState' to > > represent this connection. In 'vnc_worker_thread_loop' it creates a > > local 'VncState'. The connection 'VcnState' and

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-09-17 Thread Gerd Hoffmann
On Sat, Aug 31, 2019 at 08:39:22AM -0700, Li Qiang wrote: > Currently when qemu receives a vnc connect, it creates a 'VncState' to > represent this connection. In 'vnc_worker_thread_loop' it creates a > local 'VncState'. The connection 'VcnState' and local 'VncState' exchange > data in 'vnc_async_e

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-09-09 Thread Paolo Bonzini
On 02/09/19 11:02, Daniel P. Berrangé wrote: >>> === OUTPUT BEGIN === >>> ERROR: spaces required around that '*' (ctx:WxB) >>> #118: FILE: ui/vnc-enc-tight.c:355: >>> +data = (uint##bpp##_t *)vs->tight->tight.buffer;\ >>>^ >>> >>> >> Hello Pao

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-09-02 Thread Daniel P . Berrangé
le problems. See output below for > > more information: > > > > Type: series > > Message-id: 20190831153922.121308-1-liq...@163.com > > Subject: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect > > > > === TEST SCRIPT BEGIN === > > #!/b

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-08-31 Thread Li Qiang
190831153922.121308-1-liq...@163.com > Subject: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames Tr

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-08-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190831153922.121308-1-liq...@163.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190831153922.121308-1-liq...@163.com Subject: [Qemu-devel] [PATCH] vnc: fix memory leak

[Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-08-31 Thread Li Qiang
Currently when qemu receives a vnc connect, it creates a 'VncState' to represent this connection. In 'vnc_worker_thread_loop' it creates a local 'VncState'. The connection 'VcnState' and local 'VncState' exchange data in 'vnc_async_encoding_start' and 'vnc_async_encoding_end'. In 'zrle_compress_dat