Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Peter Lieven
Am 17.06.2013 15:58, schrieb Gerd Hoffmann: > Hi, > >>> I guess reset_keys() should skip capslock+numlock to not disturb the >>> sync logic, can you try that? >> >> mhh, i might be wrong, but where could the vs->modifiers_state be not zero >> on a new connection. I only find a g_malloc0 initiali

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Peter Lieven
Hi Gerd, just looking at your patch. It works fine so far, but I am curious how to handle the lock keys? I have the problem that if I press caps lock and then create a new vnc session with exclusive access (from another terminal), the caps lock is still there. Wouldn't it be right to release at l

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
Hi, >> I guess reset_keys() should skip capslock+numlock to not disturb the >> sync logic, can you try that? > > mhh, i might be wrong, but where could the vs->modifiers_state be not zero > on a new connection. I only find a g_malloc0 initializing the VNCState. Ah, right, it is in the per-conn

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Peter Lieven
Am 17.06.2013 14:09, schrieb Gerd Hoffmann: > On 06/17/13 13:05, Peter Lieven wrote: >> Am 17.06.2013 10:49, schrieb Gerd Hoffmann: >>> On 06/17/13 10:10, Peter Lieven wrote: Hi Gerd, just looking at your patch. It works fine so far, but I am curious how to handle the lock keys?

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 13:05, Peter Lieven wrote: > Am 17.06.2013 10:49, schrieb Gerd Hoffmann: >> On 06/17/13 10:10, Peter Lieven wrote: >>> Hi Gerd, >>> >>> just looking at your patch. It works fine so far, but I am curious how >>> to handle the lock keys? I have the problem that if I press caps lock >>> an

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Peter Lieven
Am 17.06.2013 10:49, schrieb Gerd Hoffmann: > On 06/17/13 10:10, Peter Lieven wrote: >> Hi Gerd, >> >> just looking at your patch. It works fine so far, but I am curious how >> to handle the lock keys? I have the problem that if I press caps lock >> and then create a new vnc session with exclusive

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 10:10, Peter Lieven wrote: > Hi Gerd, > > just looking at your patch. It works fine so far, but I am curious how > to handle the lock keys? I have the problem that if I press caps lock > and then create a new vnc session with exclusive access (from another > terminal), the caps lock is

[Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2012-02-08 Thread Gerd Hoffmann
For any modifier key (shift, ctrl, alt) still pressed on disconnect inject a key-up event into the guest. The vnc client is gone, it will not do that, so qemu has to do it instead. Without this keys will get stuck, making the guest act in weird ways after reconnecting. Reproducer: exit vnc clien