Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-02 Thread Jes Sorensen
On 07/01/10 19:53, Stefan Weil wrote: > Two patches are needed anyway. > > For reasons of economy, I won't send a new patch. > Feel free do send one which meets your criteria. > > Regards, > Stefan > Well if you are not interested in working the way the community works, please don't expect us t

Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Stefan Weil
Am 01.07.2010 17:53, schrieb Jes Sorensen: On 07/01/10 17:51, Stefan Weil wrote: Am 01.07.2010 15:24, schrieb Jes Sorensen: On 07/01/10 15:22, Stefan Weil wrote: It won't fail for two reasons: * It is not redefined (at least for linux systems) because I used the POSIX declar

Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Jes Sorensen
On 07/01/10 17:51, Stefan Weil wrote: > Am 01.07.2010 15:24, schrieb Jes Sorensen: >> On 07/01/10 15:22, Stefan Weil wrote: >>> It won't fail for two reasons: >>> >>> * It is not redefined (at least for linux systems) because I used the >>> POSIX declaration. >> >> This still fails with strict comp

Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Stefan Weil
Am 01.07.2010 15:24, schrieb Jes Sorensen: On 07/01/10 15:22, Stefan Weil wrote: It won't fail for two reasons: * It is not redefined (at least for linux systems) because I used the POSIX declaration. This still fails with strict compiler flags. * It is compiled only for _WIN32 (see line 95

Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Jes Sorensen
On 07/01/10 15:22, Stefan Weil wrote: > It won't fail for two reasons: > > * It is not redefined (at least for linux systems) because I used the > POSIX declaration. This still fails with strict compiler flags. > * It is compiled only for _WIN32 (see line 95). True, but we need to move stuff ou

Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Stefan Weil
Am 01.07.2010 13:50, schrieb Jes Sorensen: On 07/01/10 12:47, Stefan Weil wrote: Mingw32 does not provide a declaration and implementation of function setenv (which is used in sdl.c), so this patch adds both. Signed-off-by: Stefan Weil [snip] diff --git a/osdep.h b/osdep.h index

Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Jes Sorensen
On 07/01/10 12:47, Stefan Weil wrote: > Mingw32 does not provide a declaration and implementation of function > setenv (which is used in sdl.c), so this patch adds both. > > Signed-off-by: Stefan Weil [snip] > diff --git a/osdep.h b/osdep.h > index 75b5816..1cdc7e2 100644 > --- a/osdep.h > +++ b/

[Qemu-devel] [PATCH] win32: Add missing function setenv

2010-07-01 Thread Stefan Weil
Mingw32 does not provide a declaration and implementation of function setenv (which is used in sdl.c), so this patch adds both. Signed-off-by: Stefan Weil --- os-win32.c | 15 +++ osdep.h|2 ++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/os-win32.c b/os-