Re: [Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

2016-12-06 Thread Doug Evans
On Tue, Dec 6, 2016 at 11:43 AM, Richard Henderson wrote: > On 12/06/2016 09:13 AM, Doug Evans wrote: >> @@ -7104,6 +7104,10 @@ static target_ulong disas_insn(CPUX86State *env, >> DisasContext *s, >> gen_update_cc_op(s); >> gen_jmp_im(pc_start - s->cs_base); >> gen_helpe

Re: [Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

2016-12-06 Thread Richard Henderson
On 12/06/2016 09:13 AM, Doug Evans wrote: > @@ -7104,6 +7104,10 @@ static target_ulong disas_insn(CPUX86State *env, > DisasContext *s, > gen_update_cc_op(s); > gen_jmp_im(pc_start - s->cs_base); > gen_helper_syscall(cpu_env, tcg_const_i32(s->pc - pc_start)); > +/*

[Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

2016-12-06 Thread Doug Evans
Hi. While researching an issue related to the syscall insn it seemed like eflags status tracking was missing this step. I think(!) this is correct, it follows what similar code does elsewhere, and what the doc says. If it's not correct IWBN to clarify the situation. commit 393243eda30d4429a07a0