Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-06 Thread Alejandro Martinez
Gerd, On Tue, Sep 4, 2012 at 3:30 PM, Gerd Hoffmann kra...@redhat.com wrote: On 08/30/12 14:49, Alejandro Martinez Ruiz wrote: Some xHC drivers (most notably on Windows and BSD systems) read the first capability registers using 1 and 2 bytes accesses, since this is how they are defined in

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-06 Thread Gerd Hoffmann
Hi, usb-next will fail to compile using -Werror with: hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’: hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used [-Werror=unused-but-set-variable] Fixed. Which gcc is this? Must be pretty cutting edge, even on Fedora 17 (gcc 4.7.0) I

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-06 Thread Alejandro Martinez
Hi Gerd, On Thu, Sep 6, 2012 at 12:15 PM, Gerd Hoffmann kra...@redhat.com wrote: Hi, usb-next will fail to compile using -Werror with: hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’: hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used [-Werror=unused-but-set-variable]

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-09-04 Thread Gerd Hoffmann
On 08/30/12 14:49, Alejandro Martinez Ruiz wrote: Some xHC drivers (most notably on Windows and BSD systems) read the first capability registers using 1 and 2 bytes accesses, since this is how they are defined in section 5.3 of the xHCI specs. Enabling these kind of read accesses allows

[Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-08-30 Thread Alejandro Martinez Ruiz
Some xHC drivers (most notably on Windows and BSD systems) read the first capability registers using 1 and 2 bytes accesses, since this is how they are defined in section 5.3 of the xHCI specs. Enabling these kind of read accesses allows Windows and FreeBSD guests to properly recognize the host