Re: [Qemu-devel] [PATCH] xio3130_downstream: Report error if pcie_chassis_add_slot() failed

2017-09-19 Thread Eduardo Habkost
On Sun, Aug 27, 2017 at 10:44:26AM +0300, Marcel Apfelbaum wrote: > Hi Eduardo, > > On 25/08/2017 22:54, Eduardo Habkost wrote: > > On commit f8cd1b02 ("pci: Convert to realize"), no error_set*() > > call was added for the pcie_chassis_add_slot() error case. > > pcie_chassis_add_slot() errors get

Re: [Qemu-devel] [PATCH] xio3130_downstream: Report error if pcie_chassis_add_slot() failed

2017-08-27 Thread Marcel Apfelbaum
Hi Eduardo, On 25/08/2017 22:54, Eduardo Habkost wrote: On commit f8cd1b02 ("pci: Convert to realize"), no error_set*() call was added for the pcie_chassis_add_slot() error case. pcie_chassis_add_slot() errors get ignored, making QEMU crash later. e.g.: $ qemu-system-x86_64 -device ioh3420

[Qemu-devel] [PATCH] xio3130_downstream: Report error if pcie_chassis_add_slot() failed

2017-08-25 Thread Eduardo Habkost
On commit f8cd1b02 ("pci: Convert to realize"), no error_set*() call was added for the pcie_chassis_add_slot() error case. pcie_chassis_add_slot() errors get ignored, making QEMU crash later. e.g.: $ qemu-system-x86_64 -device ioh3420 -device xio3130-downstream qemu-system-x86_64: memory.c:21