Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-08 Thread Anthony Liguori
On 09/08/2011 05:07 AM, Avi Kivity wrote: On 09/07/2011 09:44 PM, Anthony Liguori wrote: I think this is a bit more complicated than is really needed. Here's what I came up with which also fixes another bug where the io channel could be freed twice. I stumbled across this via a very strange fai

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-08 Thread Kevin Wolf
Am 08.09.2011 12:07, schrieb Avi Kivity: > On 09/07/2011 09:44 PM, Anthony Liguori wrote: >> >> I think this is a bit more complicated than is really needed. Here's >> what I came up with which also fixes another bug where the io channel >> could be freed twice. I stumbled across this via a ver

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-08 Thread Avi Kivity
On 09/07/2011 09:44 PM, Anthony Liguori wrote: I think this is a bit more complicated than is really needed. Here's what I came up with which also fixes another bug where the io channel could be freed twice. I stumbled across this via a very strange failure scenario. Avi, it might be worth

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-07 Thread Aneesh Kumar K.V
On Wed, 07 Sep 2011 13:44:39 -0500, Anthony Liguori wrote: > On 09/07/2011 07:30 AM, Aneesh Kumar K.V wrote: > > Many users of qemu_fd_set_handler including VirtFS use NULL call back arg. > > Update fd_trampoline and qemu_fd_set_handler to work with NULL call back arg > > > > Signed-off-by: Aneesh

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-07 Thread Anthony Liguori
On 09/07/2011 07:30 AM, Aneesh Kumar K.V wrote: Many users of qemu_fd_set_handler including VirtFS use NULL call back arg. Update fd_trampoline and qemu_fd_set_handler to work with NULL call back arg Signed-off-by: Aneesh Kumar K.V --- Changes from V1: Add support for dropping event source

[Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-07 Thread Aneesh Kumar K.V
Many users of qemu_fd_set_handler including VirtFS use NULL call back arg. Update fd_trampoline and qemu_fd_set_handler to work with NULL call back arg Signed-off-by: Aneesh Kumar K.V --- Changes from V1: Add support for dropping event source iohandler.c | 31 +-