Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Michael Roth
Hi Luiz, I have these patches applied to qga branch with Eric's suggested fix-ups included. I've attached them for your review. If all looks good I'll send a PULL some time today with what's hopefully all the pending fixes for qemu-ga 1.1

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 09:56:30 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Hi Luiz, I have these patches applied to qga branch with Eric's suggested fix-ups included. I've attached them for your review. If all looks good I'll send a PULL some time today with what's hopefully all the

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Michal Privoznik
On 11.05.2012 21:19, Luiz Capitulino wrote: The main motivation for this series is fixing two possible race conditions in the guest-suspend-* API due to the complexity that arose from the way we handle terminated children processes today. Full details in the first patch. This series applies

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 19:06:28 +0200 Michal Privoznik mpriv...@redhat.com wrote: On 11.05.2012 21:19, Luiz Capitulino wrote: The main motivation for this series is fixing two possible race conditions in the guest-suspend-* API due to the complexity that arose from the way we handle

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Eric Blake
On 05/14/2012 11:06 AM, Michal Privoznik wrote: On 11.05.2012 21:19, Luiz Capitulino wrote: The main motivation for this series is fixing two possible race conditions in the guest-suspend-* API due to the complexity that arose from the way we handle terminated children processes today. Full

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Michael Roth
On Mon, May 14, 2012 at 01:39:50PM -0300, Luiz Capitulino wrote: On Mon, 14 May 2012 09:56:30 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Hi Luiz, I have these patches applied to qga branch with Eric's suggested fix-ups included. I've attached them for your review. If all

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 12:19:04 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On Mon, May 14, 2012 at 01:39:50PM -0300, Luiz Capitulino wrote: On Mon, 14 May 2012 09:56:30 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Hi Luiz, I have these patches applied to qga branch

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Michael Roth
On Mon, May 14, 2012 at 11:17:18AM -0600, Eric Blake wrote: On 05/14/2012 11:06 AM, Michal Privoznik wrote: On 11.05.2012 21:19, Luiz Capitulino wrote: The main motivation for this series is fixing two possible race conditions in the guest-suspend-* API due to the complexity that arose from

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Luiz Capitulino
On Mon, 14 May 2012 13:12:35 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Additionally, *all* commands carry the risk that qemu-ga can die (killed, crashed, guest reboots, not being installed to begin with, etc) before issuing a response, so a timeout mechanism *must* be in place if

[Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-11 Thread Luiz Capitulino
The main motivation for this series is fixing two possible race conditions in the guest-suspend-* API due to the complexity that arose from the way we handle terminated children processes today. Full details in the first patch. This series applies on top of my two other qemu-ga series submitted