Re: [Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings

2019-01-26 Thread Samuel Thibault
Hello, Peter Maydell, le mar. 22 janv. 2019 18:18:20 +, a ecrit: > These patches fix the clang -Waddress-of-packed-member warnings > in the slirp code. Applied to my tree, thanks! Eric Blake, le mar. 22 janv. 2019 13:27:32 -0600, a ecrit: > How does this series play with the ongoing effort t

Re: [Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings

2019-01-22 Thread Eric Blake
On 1/22/19 12:18 PM, Peter Maydell wrote: > These patches fix the clang -Waddress-of-packed-member warnings > in the slirp code. For slirp, the structs marked as packed > are already naturally packed/aligned, so adding the 'packed' > attribute doesn't change their layout but means the compiler > ha

[Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings

2019-01-22 Thread Peter Maydell
These patches fix the clang -Waddress-of-packed-member warnings in the slirp code. For slirp, the structs marked as packed are already naturally packed/aligned, so adding the 'packed' attribute doesn't change their layout but means the compiler has to assume they might be misaligned. Instead, for t