Re: [Qemu-devel] [PATCH 0/2] target/arm: Coverity fixups

2018-05-03 Thread Peter Maydell
On 1 May 2018 at 19:04, Richard Henderson wrote: > The first patch covers four related false positives. However, > we check the same condition twice and we certainly don't need > to that. Plus the assert might just help documentation-wise. > > The second patch covers dead code. I believe that C

[Qemu-devel] [PATCH 0/2] target/arm: Coverity fixups

2018-05-01 Thread Richard Henderson
The first patch covers four related false positives. However, we check the same condition twice and we certainly don't need to that. Plus the assert might just help documentation-wise. The second patch covers dead code. I believe that Coverity is right and that there are no paths that have !is