Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-19 Thread Avi Kivity
On 03/16/2012 10:59 AM, Amos Kong wrote: > > Can you give some detail about this? I'm not familiar with Memory API. Well there's a huge amount of detail needed here. The idea is that memory_region_add_eventfd() will always work, with or without kvm, and even if kvm is enabled but we run out of io

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-19 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 04:59:35PM +0800, Amos Kong wrote: > On 14/03/12 19:46, Stefan Hajnoczi wrote: > >On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity wrote: > >>On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: > >>>On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > On 03/14/2012 11:59 AM, S

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-16 Thread Amos Kong
On 14/03/12 19:46, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity wrote: On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote:

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity wrote: > On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: >> On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: >> > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: >> >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: >> >> > On 03/13/2012 12:42 PM,

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: > On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: > >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > >> > On 03/13/2012 12:42 PM, Amos Kong wrote: > >> >> Boot up guest with 232 virtio-blk

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: >> On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: >> > On 03/13/2012 12:42 PM, Amos Kong wrote: >> >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >> >> allocate ioevent

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: > On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > > On 03/13/2012 12:42 PM, Amos Kong wrote: > >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > >> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > >> a

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity wrote: > On 03/13/2012 12:42 PM, Amos Kong wrote: >> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), >> and check if available ioeventfd exists. If not, virtio-pc

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Avi Kivity
On 03/13/2012 12:42 PM, Amos Kong wrote: > Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > and check if available ioeventfd exists. If not, virtio-pci will > fallback to userspace, and don't use ioeventfd f

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 12:30 AM, Amos Kong wrote: > - Original Message - >> On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong wrote: > > ... > > Hi, Stefan > >> > diff --git a/kvm-all.c b/kvm-all.c >> > index 77eadf6..7157e78 100644 >> > --- a/kvm-all.c >> > +++ b/kvm-all.c >> > @@ -771,6 +771,

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Amos Kong
- Original Message - > On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong wrote: ... Hi, Stefan > > diff --git a/kvm-all.c b/kvm-all.c > > index 77eadf6..7157e78 100644 > > --- a/kvm-all.c > > +++ b/kvm-all.c > > @@ -771,6 +771,8 @@ static void > > kvm_io_ioeventfd_add(MemoryRegionSection *sect

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong wrote: > - Original Message - >> On Tue, Mar 13, 2012 at 11:51 AM, Amos Kong wrote: >> > On 13/03/12 19:23, Stefan Hajnoczi wrote: >> >> >> >> On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong >> >>  wrote: >> >>> >> >>> Boot up guest with 232 virtio-b

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Amos Kong
- Original Message - > On Tue, Mar 13, 2012 at 11:51 AM, Amos Kong wrote: > > On 13/03/12 19:23, Stefan Hajnoczi wrote: > >> > >> On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong > >>  wrote: > >>> > >>> Boot up guest with 232 virtio-blk disk, qemu will abort for fail > >>> to > >>> allocate io

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 11:51 AM, Amos Kong wrote: > On 13/03/12 19:23, Stefan Hajnoczi wrote: >> >> On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong  wrote: >>> >>> Boot up guest with 232 virtio-blk disk, qemu will abort for fail to >>> allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Amos Kong
On 13/03/12 19:23, Stefan Hajnoczi wrote: On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not, virtio-pci will

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong wrote: > Boot up guest with 232 virtio-blk disk, qemu will abort for fail to > allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), > and check if available ioeventfd exists. If not, virtio-pci will > fallback to userspace, and don't use

[Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Amos Kong
Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not, virtio-pci will fallback to userspace, and don't use ioeventfd for io notification. --- Amos Kong (2): re