Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-18 Thread Peter Maydell
On 10 March 2013 13:47, Igor Mitsyanko wrote: > hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for > dynamically > allocated buffer migration, this was causing memory corruption. > Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag > set) instead. > > N

Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-15 Thread Igor Mitsyanko
> On 03/15/2013 09:12 PM, Peter Maydell wrote: > >> On 10 March 2013 13:47, Igor Mitsyanko wrote: >> >>> hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for >>> dynamically >>> allocated buffer migration, this was causing memory corruption. >>> Use VMSTATE_BUFFER_POINTER_UNSAFE (

Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-15 Thread Peter Maydell
On 10 March 2013 13:47, Igor Mitsyanko wrote: > hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for > dynamically > allocated buffer migration, this was causing memory corruption. > Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag > set) instead. > > N

[Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-10 Thread Igor Mitsyanko
hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for dynamically allocated buffer migration, this was causing memory corruption. Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag set) instead. Not sure what to do with vmstate version for his devices, sh