[Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com I noticed this commit, virtio-pci: add missing 'static' which made this change: -const MemoryRegionPortio virtio_portio[] = { +static const MemoryRegionPortio virtio_portio[] = { and wondered if there were other variables like that. The

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made this change:     -const MemoryRegionPortio virtio_portio[] = {     +static const MemoryRegionPortio

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made this change:     -const MemoryRegionPortio virtio_portio[] = {     +static const

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 6:10 PM, Jim Meyering j...@meyering.net wrote: Blue Swirl wrote: On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made this change:    

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: On Mon, May 21, 2012 at 6:10 PM, Jim Meyering j...@meyering.net wrote: Blue Swirl wrote: On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made