Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-21 Thread Peter Xu
On Wed, Aug 22, 2018 at 11:46:32AM +0800, Peter Xu wrote: > On Tue, Aug 21, 2018 at 04:16:27PM +0200, Paolo Bonzini wrote: > > On 21/08/2018 16:04, Marc-André Lureau wrote: > > >> If you don't like the way I proposed, another thing I am > > >> thinking is that whether we can assign the gcontext for

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-21 Thread Peter Xu
On Tue, Aug 21, 2018 at 04:16:27PM +0200, Paolo Bonzini wrote: > On 21/08/2018 16:04, Marc-André Lureau wrote: > >> If you don't like the way I proposed, another thing I am > >> thinking is that whether we can assign the gcontext for the chardev > >> backend before initialization of it (or by parsi

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-21 Thread Daniel P . Berrangé
On Tue, Aug 21, 2018 at 04:04:45PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Aug 21, 2018 at 8:29 AM Peter Xu wrote: > > I fully agree that current way is not ideal since basically the > > backend should not depend on the frontend, but now we have the > > gcontext as an exception then the

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-21 Thread Paolo Bonzini
On 21/08/2018 16:04, Marc-André Lureau wrote: >> If you don't like the way I proposed, another thing I am >> thinking is that whether we can assign the gcontext for the chardev >> backend before initialization of it (or by parsing the backend & >> frontend relationships before init of backends), th

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-21 Thread Marc-André Lureau
Hi On Tue, Aug 21, 2018 at 8:29 AM Peter Xu wrote: > > On Mon, Aug 20, 2018 at 05:37:55PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, Aug 20, 2018 at 4:48 AM Peter Xu wrote: > > > > > > On Fri, Aug 17, 2018 at 03:52:20PM +0200, Marc-André Lureau wrote: > > > > Hi, > > > > > > > > In c

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-20 Thread Peter Xu
On Mon, Aug 20, 2018 at 05:37:55PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Aug 20, 2018 at 4:48 AM Peter Xu wrote: > > > > On Fri, Aug 17, 2018 at 03:52:20PM +0200, Marc-André Lureau wrote: > > > Hi, > > > > > > In commit 25679e5d58e "chardev: tcp: postpone async connection setup" > > >

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-20 Thread Marc-André Lureau
Hi On Mon, Aug 20, 2018 at 4:48 AM Peter Xu wrote: > > On Fri, Aug 17, 2018 at 03:52:20PM +0200, Marc-André Lureau wrote: > > Hi, > > > > In commit 25679e5d58e "chardev: tcp: postpone async connection setup" > > (and its follow up 99f2f54174a59), Peter moved chardev socket > > connection to machi

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-19 Thread Peter Xu
On Fri, Aug 17, 2018 at 03:52:20PM +0200, Marc-André Lureau wrote: > Hi, > > In commit 25679e5d58e "chardev: tcp: postpone async connection setup" > (and its follow up 99f2f54174a59), Peter moved chardev socket > connection to machine_done event. However, chardev created later will > no longer att

[Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-17 Thread Marc-André Lureau
Hi, In commit 25679e5d58e "chardev: tcp: postpone async connection setup" (and its follow up 99f2f54174a59), Peter moved chardev socket connection to machine_done event. However, chardev created later will no longer attempt to connect, and chardev created in tests do not have machine_done event (b