Re: [Qemu-devel] [PATCH 0/4] lsi: small cleanup and add 53C810 variant

2013-09-14 Thread Paolo Bonzini
Il 13/09/2013 21:50, Hervé Poussineau ha scritto: Patch 4 may be more controversial, as it adds support for an older (albeit compatible) SCSI adapter, without removing emulation of newer features. I don't think that's a huge problem, but please add a comment about it. Paolo

Re: [Qemu-devel] [PATCH 0/4] lsi: small cleanup and add 53C810 variant

2013-09-14 Thread Hervé Poussineau
Paolo Bonzini a écrit : Il 13/09/2013 21:50, Hervé Poussineau ha scritto: Patch 4 may be more controversial, as it adds support for an older (albeit compatible) SCSI adapter, without removing emulation of newer features. I don't think that's a huge problem, but please add a comment about it.

[Qemu-devel] [PATCH 0/4] lsi: small cleanup and add 53C810 variant

2013-09-13 Thread Hervé Poussineau
Hi, This small patchset fixes a few issues I encountered while trying to add support for the IBM RS/6000 40p. Patches 1 to 3 are small cleanups. Patch 4 may be more controversial, as it adds support for an older (albeit compatible) SCSI adapter, without removing emulation of newer features.

Re: [Qemu-devel] [PATCH 0/4] lsi: small cleanup and add 53C810 variant

2013-09-13 Thread Peter Maydell
On 13 September 2013 20:50, Hervé Poussineau hpous...@reactos.org wrote: However, there is some precedence in QEMU codebase, where for example Intel 486 CPU can execute cmov instructions (like cmov) Poor choice of example, since that's just a bug and the fix is hopefully going to get committed