Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 02:14:30PM +0200, Cornelia Huck wrote: > On Mon, 20 Apr 2015 11:12:37 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 20, 2015 at 10:54:11AM +0200, Cornelia Huck wrote: > > > On Fri, 17 Apr 2015 15:00:45 +0100 > > > Peter Maydell wrote: > > > > > > > On 17 April 20

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Cornelia Huck
On Mon, 20 Apr 2015 11:12:37 +0200 "Michael S. Tsirkin" wrote: > On Mon, Apr 20, 2015 at 10:54:11AM +0200, Cornelia Huck wrote: > > On Fri, 17 Apr 2015 15:00:45 +0100 > > Peter Maydell wrote: > > > > > On 17 April 2015 at 14:43, Cornelia Huck wrote: > > > > On Fri, 17 Apr 2015 20:13:42 +0800 >

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 10:54:11AM +0200, Cornelia Huck wrote: > On Fri, 17 Apr 2015 15:00:45 +0100 > Peter Maydell wrote: > > > On 17 April 2015 at 14:43, Cornelia Huck wrote: > > > On Fri, 17 Apr 2015 20:13:42 +0800 > > > Shannon Zhao wrote: > > > > > > [Some questions may be silly, but I'm n

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Peter Maydell
On 20 April 2015 at 09:54, Cornelia Huck wrote: > The reason why blk is ok is that it adds the feature bits in its > ->get_features() callback. net expects the feature bits already present > and removes not supported ones and therefore requires > statically-defined bits somewhere. > > If we move t

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-20 Thread Cornelia Huck
On Fri, 17 Apr 2015 15:00:45 +0100 Peter Maydell wrote: > On 17 April 2015 at 14:43, Cornelia Huck wrote: > > On Fri, 17 Apr 2015 20:13:42 +0800 > > Shannon Zhao wrote: > > > > [Some questions may be silly, but I'm not familiar with the virtio-mmio > > code] > > > >> The reason to do this is th

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 14:43, Cornelia Huck wrote: > On Fri, 17 Apr 2015 20:13:42 +0800 > Shannon Zhao wrote: > > [Some questions may be silly, but I'm not familiar with the virtio-mmio > code] > >> The reason to do this is that the virtio-net-device can't expose host >> features to guest while usin

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 20:13:42 +0800 Shannon Zhao wrote: [Some questions may be silly, but I'm not familiar with the virtio-mmio code] > The reason to do this is that the virtio-net-device can't expose host > features to guest while using virtio-mmio. So the performance is low. So how does virtio

[Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-17 Thread Shannon Zhao
The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the ability to forward property accesses to the backend child, by calling *_virtio_*_instance_