Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-23 Thread Juan Quintela
Alexander Graf wrote: > On 22.02.2012, at 17:09, Peter Maydell wrote: > >> On 22 February 2012 16:04, Andreas Färber wrote: >>> Am 22.02.2012 16:42, schrieb Peter Maydell: On 22 February 2012 15:37, Andreas Färber wrote: > NB: Your cpu-vmstate patches were not applied so far and they ap

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Alexander Graf
On 22.02.2012, at 17:09, Peter Maydell wrote: > On 22 February 2012 16:04, Andreas Färber wrote: >> Am 22.02.2012 16:42, schrieb Peter Maydell: >>> On 22 February 2012 15:37, Andreas Färber wrote: NB: Your cpu-vmstate patches were not applied so far and they appear to conflict with th

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 16:04, Andreas Färber wrote: > Am 22.02.2012 16:42, schrieb Peter Maydell: >> On 22 February 2012 15:37, Andreas Färber wrote: >>> NB: Your cpu-vmstate patches were not applied so far and they appear to >>> conflict with the plans we've made for redesigning cp15 on ARM: We wan

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Andreas Färber
Am 22.02.2012 16:42, schrieb Peter Maydell: > On 22 February 2012 15:37, Andreas Färber wrote: >> NB: Your cpu-vmstate patches were not applied so far and they appear to >> conflict with the plans we've made for redesigning cp15 on ARM: We want >> to convert today's static fields to some list and

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 15:37, Andreas Färber wrote: > NB: Your cpu-vmstate patches were not applied so far and they appear to > conflict with the plans we've made for redesigning cp15 on ARM: We want > to convert today's static fields to some list and were hoping to have a > mapping function for back

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Andreas Färber
Am 22.02.2012 15:02, schrieb Juan Quintela: > Peter Maydell wrote: >> On 22 February 2012 10:15, Igor Mitsyanko wrote: >>> This patchset cleans up and optimizes vmstate implementation. >>> >>> Patch 1 is a trivial bug fixing. >>> Patches 2 and 3 replaces target_phys_addr_t in pxa implementation >

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Juan Quintela
Peter Maydell wrote: > On 22 February 2012 10:15, Igor Mitsyanko wrote: >> This patchset cleans up and optimizes vmstate implementation. >> >> Patch 1 is a trivial bug fixing. >> Patches 2 and 3 replaces target_phys_addr_t in pxa implementation >> to uint32_t. >> Patch 4 moves VMSTATE_UINTTL from

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 12:49, Andreas Färber wrote: > Am 22.02.2012 12:26, schrieb Peter Maydell: >> So if we apply patches 1-3 (which all look plausible) then the only >> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as >> I can see. >> >> This leaves me wondering if we shouldn't

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Andreas Färber
Am 22.02.2012 12:26, schrieb Peter Maydell: > So if we apply patches 1-3 (which all look plausible) then the only > remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as > I can see. > > This leaves me wondering if we shouldn't just put it actually in > target-i386/machine.c as a con

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 10:15, Igor Mitsyanko wrote: > Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency > on NEED_CPU_H is droped, I failed to understand why it was presented at all. You need #ifdef NEED_CPU_H because in generic source files (where NEED_CPU_H is not defined) t

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Mitsyanko Igor
On 02/22/2012 03:26 PM, Peter Maydell wrote: On 22 February 2012 10:15, Igor Mitsyanko wrote: This patchset cleans up and optimizes vmstate implementation. Patch 1 is a trivial bug fixing. Patches 2 and 3 replaces target_phys_addr_t in pxa implementation to uint32_t. Patch 4 moves VMSTATE_UINT

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Peter Maydell
On 22 February 2012 10:15, Igor Mitsyanko wrote: > This patchset cleans up and optimizes vmstate implementation. > > Patch 1 is a trivial bug fixing. > Patches 2 and 3 replaces target_phys_addr_t in pxa implementation > to uint32_t. > Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit d

[Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-22 Thread Igor Mitsyanko
This patchset cleans up and optimizes vmstate implementation. Patch 1 is a trivial bug fixing. Patches 2 and 3 replaces target_phys_addr_t in pxa implementation to uint32_t. Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency on NEED_CPU_H is droped, I failed to understand why