[Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-17 Thread Michael S. Tsirkin
At the moment we migrate ROMs which reside in fw cfg, which allows changing ROM code at will, and supports migrating largish blocks early, with good performance. However, we are running into a problem: changing size breaks migration every time. This already requires somewhat messy compatibility sup

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [22:11:13], Michael S. Tsirkin wrote: > And to make it clear, I'd like to see review from > migration maintainers on this. > The patchset crosses into pc so it's probably best to > merge through my tree to avoic conflicts. Fine by me. Amit

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: > At the moment we migrate ROMs which reside in fw cfg, which allows > changing ROM code at will, and supports migrating largish blocks early, > with good performance. > However, we are running into a problem: changing size breaks > migrati

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 01:01:14PM +0530, Amit Shah wrote: > On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: > > At the moment we migrate ROMs which reside in fw cfg, which allows > > changing ROM code at will, and supports migrating largish blocks early, > > with good performance. > > H

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Nov 18, 2014 at 03:47:16PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > At the moment we migrate ROMs which reside in fw cfg, which allows >> > changing ROM code at will, and supports migrating largish blocks early, >> > with goo

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Amit Shah
On (Wed) 19 Nov 2014 [10:15:16], Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 01:01:14PM +0530, Amit Shah wrote: > > On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: > > > Note: migration stream is unaffected by these patches. > > > This makes it possible to enable this functional

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 01:52:35PM +0530, Amit Shah wrote: > On (Wed) 19 Nov 2014 [10:15:16], Michael S. Tsirkin wrote: > > On Wed, Nov 19, 2014 at 01:01:14PM +0530, Amit Shah wrote: > > > On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: > > > > > Note: migration stream is unaffected by

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 09:16:09AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Nov 18, 2014 at 03:47:16PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > At the moment we migrate ROMs which reside in fw cfg, which allows > >> > chan

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Peter Maydell
On 19 November 2014 07:31, Amit Shah wrote: > On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: >> Considering this promises to rid us of worries about ROM size considerations >> once and for all, I thinking about pushing this as a "kind of bugfix" before >> 2.2, so we don't need to maint

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Nov 19, 2014 at 01:52:35PM +0530, Amit Shah wrote: >> On (Wed) 19 Nov 2014 [10:15:16], Michael S. Tsirkin wrote: >> > On Wed, Nov 19, 2014 at 01:01:14PM +0530, Amit Shah wrote: >> > > On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: >> >> > > > Note

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Paolo Bonzini
On 19/11/2014 14:52, Peter Maydell wrote: > It certainly seems pretty risky to introduce this change with > only two weeks to go til release; I wouldn't want to merge it > without a strong consensus from everybody involved that it > really needed to go in for 2.2. I think there's consensus (you,

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 03:41:23PM +0100, Paolo Bonzini wrote: > > > On 19/11/2014 14:52, Peter Maydell wrote: > > It certainly seems pretty risky to introduce this change with > > only two weeks to go til release; I wouldn't want to merge it > > without a strong consensus from everybody involved

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 02:52:43PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Nov 19, 2014 at 01:52:35PM +0530, Amit Shah wrote: > >> On (Wed) 19 Nov 2014 [10:15:16], Michael S. Tsirkin wrote: > >> > On Wed, Nov 19, 2014 at 01:01:14PM +0530, Amit Shah wrote: > >> > > On

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-19 Thread Juan Quintela
Paolo Bonzini wrote: > On 19/11/2014 14:52, Peter Maydell wrote: >> It certainly seems pretty risky to introduce this change with >> only two weeks to go til release; I wouldn't want to merge it >> without a strong consensus from everybody involved that it >> really needed to go in for 2.2. > > I

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-17 Thread Michael S. Tsirkin
On Mon, Nov 17, 2014 at 10:08:46PM +0200, Michael S. Tsirkin wrote: > At the moment we migrate ROMs which reside in fw cfg, which allows > changing ROM code at will, and supports migrating largish blocks early, > with good performance. > However, we are running into a problem: changing size breaks

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Michael S. Tsirkin
On Tue, Nov 18, 2014 at 03:47:16PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > At the moment we migrate ROMs which reside in fw cfg, which allows > > changing ROM code at will, and supports migrating largish blocks early, > > with good performance. > > However, we are run

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > At the moment we migrate ROMs which reside in fw cfg, which allows > changing ROM code at will, and supports migrating largish blocks early, > with good performance. > However, we are running into a problem: changing size breaks > migration every time. Pardon my ig