Re: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-19 Thread Anthony Liguori
On 01/14/2010 09:34 AM, Amit Shah wrote: On (Thu) Jan 14 2010 [08:34:42], Anthony Liguori wrote: On 01/14/2010 07:17 AM, Amit Shah wrote: Hello people, This iteration of the series removes the START and END flags (and hence the header associated with each buffer). That's the major

Re: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-19 Thread Amit Shah
On (Tue) Jan 19 2010 [17:59:33], Jamie Lokier wrote: What happens if the guest crashes, kexecs or whatever when it's half way through sending a cut buffer? A stream protocol will not have a nice way to recover from that unless there is an additional out of band way to say I'm starting

[Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-19 Thread Amit Shah
Hello all, In this series I've removed the buffering that happened in the host and ack the amount of data that ports actually consume. This basically removes the older patch 5/8 that introduced buffering and throttling. Other changes include addition of patch 8: MSI support and ensuring we don't

[Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-14 Thread Amit Shah
Hello people, This iteration of the series removes the START and END flags (and hence the header associated with each buffer). That's the major change since the last submission. Please review. Obligatory disclaimer: This series splits up the patches by functionality. Note, however, that patches

Re: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-14 Thread Anthony Liguori
On 01/14/2010 07:17 AM, Amit Shah wrote: Hello people, This iteration of the series removes the START and END flags (and hence the header associated with each buffer). That's the major change since the last submission. I think the biggest issue remaining is the buffering. I think this is

[Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-06 Thread Amit Shah
Hello, This series addresses comments from last time: - use ldl/stl instead of communicating in little endian. - virtio-serial-bus is back in Makefile.target as a result of the above change. - don't write to guest memory in handle_control_message - is_console is a property; remove from custom

[Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2010-01-04 Thread Amit Shah
Hello, This series addresses some comments from last time: - locking is removed - send/receive struct elements in endian-safe way - appropriate device is created based on machine being used (virtio-serial-pci vs virtio-serial-s390). This series splits up the patches by functionality. Note,