Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 06:03, Lei Li ha scritto: Hi Paolo, When debugging the code, I realized that this problem might still exist. In the incoming part, it will qemu_fopen_pipe() in unix_accept_incoming_migration first to enable the load_hook callback, the check action of this RAM_SAVE_FLAG_HOOK

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Lei Li
On 10/03/2013 04:23 PM, Paolo Bonzini wrote: Il 03/10/2013 06:03, Lei Li ha scritto: Hi Paolo, When debugging the code, I realized that this problem might still exist. In the incoming part, it will qemu_fopen_pipe() in unix_accept_incoming_migration first to enable the load_hook callback, the

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 12:28, Lei Li ha scritto: The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is received. To check this flags, it means there would be a check action first in unix_accept_incoming_migration(), like: f = qemu_fopen_pipe(c, rb); flags = qemu_get_be64(f); if

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Lei Li
On 10/03/2013 06:34 PM, Paolo Bonzini wrote: Il 03/10/2013 12:28, Lei Li ha scritto: The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is received. To check this flags, it means there would be a check action first in unix_accept_incoming_migration(), like: f =

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 15:29, Lei Li ha scritto: On 10/03/2013 06:34 PM, Paolo Bonzini wrote: Il 03/10/2013 12:28, Lei Li ha scritto: The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is received. To check this flags, it means there would be a check action first in

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Lei Li
On 10/03/2013 09:34 PM, Paolo Bonzini wrote: Il 03/10/2013 15:29, Lei Li ha scritto: On 10/03/2013 06:34 PM, Paolo Bonzini wrote: Il 03/10/2013 12:28, Lei Li ha scritto: The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is received. To check this flags, it means there would

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-02 Thread Lei Li
On 09/26/2013 08:44 PM, Lei Li wrote: On 09/25/2013 11:02 PM, Paolo Bonzini wrote: Il 25/09/2013 16:32, Lei Li ha scritto: This RFC patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel will be

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-09-26 Thread Lei Li
On 09/25/2013 11:02 PM, Paolo Bonzini wrote: Il 25/09/2013 16:32, Lei Li ha scritto: This RFC patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel will be used for the page flipping by vmsplice,

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-09-26 Thread Paolo Bonzini
Il 26/09/2013 14:44, Lei Li ha scritto: The basis of your code will still be the socket-based QEMUFile, but you'll need your own QEMUFile since you're adding Unix-specific functionality. For this it is not a problem to have two copies the QEMUFile code for sockets, one in savevm.c and one in

[Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-09-25 Thread Lei Li
This RFC patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel will be used for the page flipping by vmsplice, which will be the internal mechanism for localhost migration that we are trying to add.

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-09-25 Thread Paolo Bonzini
Il 25/09/2013 16:32, Lei Li ha scritto: This RFC patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel will be used for the page flipping by vmsplice, which will be the internal mechanism for