On 13 August 2015 at 18:37, Peter Maydell wrote:
> On 22 July 2015 at 17:43, Peter Maydell wrote:
>> This series makes a start at cleaning up some of our headers
>> to avoid the common problem of header files including qemu-common.h
>> (which then in turn can lead to awkward circular includes).
>
On 22 July 2015 at 17:43, Peter Maydell wrote:
> This series makes a start at cleaning up some of our headers
> to avoid the common problem of header files including qemu-common.h
> (which then in turn can lead to awkward circular includes).
The general consensus here seems to be that patches 1-9
On Fri, Jul 31, 2015 at 01:57:29PM +0100, Peter Maydell wrote:
> On 31 July 2015 at 13:54, Daniel P. Berrange wrote:
> > I broadly like the direction of this change. I think it is
> > probably worth being strict about requiring #include of
> > osdep.h as the first header in every .c file. And vali
On 31 July 2015 at 13:54, Daniel P. Berrange wrote:
> I broadly like the direction of this change. I think it is
> probably worth being strict about requiring #include of
> osdep.h as the first header in every .c file. And validating
> such a rule programmatically at make check time or equiv.
Yea
On Wed, Jul 22, 2015 at 05:43:59PM +0100, Peter Maydell wrote:
> This series makes a start at cleaning up some of our headers
> to avoid the common problem of header files including qemu-common.h
> (which then in turn can lead to awkward circular includes).
>
> One common cause of this is that we
Peter Maydell writes:
> This series makes a start at cleaning up some of our headers
> to avoid the common problem of header files including qemu-common.h
> (which then in turn can lead to awkward circular includes).
Yes, please!
> One common cause of this is that we don't have any header
> whi
On 22/07/2015 18:43, Peter Maydell wrote:
> The real question here I guess is whether people like the
> direction I'm trying to go with this. If so, we can further
> reduce the number of qemu-common.h includes without too much
> difficulty with further patches.
I like it, and it nicely complemen
This series makes a start at cleaning up some of our headers
to avoid the common problem of header files including qemu-common.h
(which then in turn can lead to awkward circular includes).
One common cause of this is that we don't have any header
which will include the basic things most header fil
