Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting

2017-04-24 Thread Markus Armbruster
Fam Zheng writes: > These are patches to: > > 1) reorder the function parameters so that Error **errp comes > last. > > Error pointer in the middle of a function parameter list is very uncommon, and > does caused mistakes, thus is not a good style. Change to the usual way. > >

Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting

2017-04-21 Thread Markus Armbruster
Fam Zheng writes: > These are patches to: > > 1) reorder the function parameters so that Error **errp comes > last. > > Error pointer in the middle of a function parameter list is very uncommon, and > does caused mistakes, thus is not a good style. Change to the usual way. > >

Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting

2017-04-21 Thread Eric Blake
On 04/21/2017 07:26 AM, Fam Zheng wrote: > These are patches to: > > 1) reorder the function parameters so that Error **errp comes > last. > > Error pointer in the middle of a function parameter list is very uncommon, and > does caused mistakes, thus is not a good style. Change to the usual way.

[Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting

2017-04-21 Thread Fam Zheng
These are patches to: 1) reorder the function parameters so that Error **errp comes last. Error pointer in the middle of a function parameter list is very uncommon, and does caused mistakes, thus is not a good style. Change to the usual way. 2) apply the error_propagate_null.cocci semantics