Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-16 Thread Richard Henderson
On 01/15/2015 07:01 AM, Peter Maydell wrote: > I was looking at our confusing mess of memory accessor functions, > and I realised that partly it was confusing because we have a > bunch of unnecessary junk lurking in there :-) This series > attempts to clean things up by removing things we weren't u

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 20:10, Lluís Vilanova wrote: > Peter Maydell writes: > >> On 15 January 2015 at 15:32, Lluís Vilanova wrote: >>> I haven't reviewed the patches, but that's a much appreciated cleanup! I was >>> also trying to make sense of all the variants while implementing guest >>> memory >>>

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Lluís Vilanova
Peter Maydell writes: > On 15 January 2015 at 15:32, Lluís Vilanova wrote: >> I haven't reviewed the patches, but that's a much appreciated cleanup! I was >> also trying to make sense of all the variants while implementing guest memory >> access tracing > I drew the following terrible ASCII art

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Peter Maydell
On 15 January 2015 at 15:32, Lluís Vilanova wrote: > I haven't reviewed the patches, but that's a much appreciated cleanup! I was > also trying to make sense of all the variants while implementing guest memory > access tracing I drew the following terrible ASCII art diagram of the remaining memor

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Lluís Vilanova
Peter Maydell writes: > I was looking at our confusing mess of memory accessor functions, > and I realised that partly it was confusing because we have a > bunch of unnecessary junk lurking in there :-) This series > attempts to clean things up by removing things we weren't using > at all or were

[Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Peter Maydell
I was looking at our confusing mess of memory accessor functions, and I realised that partly it was confusing because we have a bunch of unnecessary junk lurking in there :-) This series attempts to clean things up by removing things we weren't using at all or were only using by mistake in a few pl