Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-23 Thread Stefan Hajnoczi
On Fri, Jan 20, 2017 at 05:39:40PM +0100, Paolo Bonzini wrote: > > > On 19/01/2017 18:01, Stefan Hajnoczi wrote: > >>> This is a big and somewhat risky change. Have you run any performance > >>> benchmarks? > >> > >> Not recently; I ran them a year ago and there was no measurable difference. > >

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-20 Thread Paolo Bonzini
On 19/01/2017 18:01, Stefan Hajnoczi wrote: >>> This is a big and somewhat risky change. Have you run any performance >>> benchmarks? >> >> Not recently; I ran them a year ago and there was no measurable difference. > > Good, please re-run for the final version. Done, went better than expected

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 05:31:03PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 17:03, Stefan Hajnoczi wrote: > > On Fri, Jan 13, 2017 at 02:17:15PM +0100, Paolo Bonzini wrote: > >> This series pushes down aio_context_acquire/release to the point > >> where we can actually reason on using diff

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-18 Thread Paolo Bonzini
On 18/01/2017 17:03, Stefan Hajnoczi wrote: > On Fri, Jan 13, 2017 at 02:17:15PM +0100, Paolo Bonzini wrote: >> This series pushes down aio_context_acquire/release to the point >> where we can actually reason on using different fine-grained mutexes. >> >> The main infrastructure is introduced in

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-18 Thread Paolo Bonzini
On 18/01/2017 17:02, Stefan Hajnoczi wrote: > On Fri, Jan 13, 2017 at 02:17:15PM +0100, Paolo Bonzini wrote: >> hw/block/virtio-blk.c | 19 +++- >> hw/scsi/scsi-bus.c | 2 + >> hw/scsi/scsi-disk.c| 15 +++ >> hw/scsi/scsi-generic.c | 20 +++- >> hw/s

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:15PM +0100, Paolo Bonzini wrote: > This series pushes down aio_context_acquire/release to the point > where we can actually reason on using different fine-grained mutexes. > > The main infrastructure is introduced in patch 1. The new API aio_co_wake > starts a corout

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:15PM +0100, Paolo Bonzini wrote: > hw/block/virtio-blk.c | 19 +++- > hw/scsi/scsi-bus.c | 2 + > hw/scsi/scsi-disk.c| 15 +++ > hw/scsi/scsi-generic.c | 20 +++- > hw/scsi/virtio-scsi.c | 6 ++ Are all the othe

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-16 Thread Fam Zheng
On Fri, 01/13 14:17, Paolo Bonzini wrote: > Paolo Bonzini (16): > aio: introduce aio_co_schedule and aio_co_wake > block-backend: allow blk_prw from coroutine context > test-thread-pool: use generic AioContext infrastructure > io: add methods to set I/O handlers on AioContext > io: make q

[Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-13 Thread Paolo Bonzini
This series pushes down aio_context_acquire/release to the point where we can actually reason on using different fine-grained mutexes. The main infrastructure is introduced in patch 1. The new API aio_co_wake starts a coroutine with aio_context_acquire/release protection, which requires tracking