Re: [Qemu-devel] [PATCH 00/16] qom: Assert sufficient object instance size

2013-08-30 Thread Andreas Färber
Am 24.08.2013 02:00, schrieb Andreas Färber: Andreas Färber (16): qom: Fix object_initialize_with_type() argument name in documentation intel-hda: Pass size to hda_codec_bus_init() ipack: Pass size to ipack_bus_new_inplace() ide: Pass size to ide_bus_new() pci: Pass size to

Re: [Qemu-devel] [PATCH 00/16] qom: Assert sufficient object instance size

2013-08-26 Thread Wenchao Xia
I have not looked deep into QOM, so only reviewed the code in this series, and have some minor comments for patch 12, 13, and 15. For other part, Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Hello, Peter remarked that object_initialize() on a GICState struct field would not check

[Qemu-devel] [PATCH 00/16] qom: Assert sufficient object instance size

2013-08-23 Thread Andreas Färber
Hello, Peter remarked that object_initialize() on a GICState struct field would not check whether the TypeInfo::instance_size for its typename argument exceeds the length of the field we're initializing. This series therefore updates all callers to explicitly pass the size available for the