Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-02-01 Thread Cleber Rosa
On 2/1/19 12:32 AM, Aleksandar Markovic wrote: >>> I think, the term "arch" is a little problematic in QEMU parlance. IMHO, >>> "target" should be used instead. ("arch" is used in Linux kernel community) > >> Naming things is hard, so this is a valid discussion. But, I have to >> say that I al

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-31 Thread Aleksandar Markovic
>> I think, the term "arch" is a little problematic in QEMU parlance. IMHO, >> "target" should be used instead. ("arch" is used in Linux kernel community) > Naming things is hard, so this is a valid discussion. But, I have to > say that I also find "arch" in this context to be descriptive enough.

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190117185628.21862-1-cr...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support Type: series Message-id

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-31 Thread Cleber Rosa
On 1/22/19 5:48 AM, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > On 1/21/19 11:15 PM, Aleksandar Markovic wrote: >>> From: Cleber Rosa >> >>> class My(Test): >>> def test_nx_cpu_flag(self): >>> """ >>> :avocado: tags=arch:x86_64 >>> """ >>>

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-22 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 1/21/19 11:15 PM, Aleksandar Markovic wrote: >> From: Cleber Rosa > >> class My(Test): >> def test_nx_cpu_flag(self): >> """ >> :avocado: tags=arch:x86_64 >> """ >> test_code() > >> The value of the "arch" key, in this case, "x86

Re: [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-21 Thread Aleksandar Markovic
> From: Cleber Rosa > class My(Test): > def test_nx_cpu_flag(self): > """ > :avocado: tags=arch:x86_64 > """ > test_code() > The value of the "arch" key, in this case, "x86_64" will be used when > selecting the QEMU binary to use in the test. At t

[Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-17 Thread Cleber Rosa
The current acceptance tests don't provide any type of architecture information that can be used to influence the selection of the QEMU binary used on them[1]. If one is running tests on a x86_64 host, the default QEMU binary will be "x86_64-softmmu/qemu-system-x86_64". Given the nature of QEMU,