Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Paolo Bonzini
On 20/04/2015 22:34, Michael S. Tsirkin wrote: On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to have missed: DMA to invalid memory addresses causes a crash in memory

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 01:50:33PM +0800, Fam Zheng wrote: On Tue, 04/21 07:22, Michael S. Tsirkin wrote: On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: On Mon, 04/20 19:36, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: Currently,

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Fam Zheng
On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Fam Zheng
On Tue, 04/21 11:08, Cornelia Huck wrote: On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 08:52:36AM +0200, Paolo Bonzini wrote: On 20/04/2015 22:34, Michael S. Tsirkin wrote: On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Fam Zheng
On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 04/20 17:13, Cornelia Huck wrote: On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 05:16:53PM +0800, Fam Zheng wrote: On Tue, 04/21 11:08, Cornelia Huck wrote: On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 10:04, Cornelia Huck wrote: On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng f...@redhat.com wrote:

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 17:16:53 +0800 Fam Zheng f...@redhat.com wrote: On Tue, 04/21 11:08, Cornelia Huck wrote: My concern is mainly about legacy setups that aren't used interactively. How about pausing guest and generating an QMP event? That sounds good as well.

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to have missed: DMA to invalid memory addresses causes a crash in memory core. I'm not sure whether it makes sense to

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Fam Zheng
On Mon, 04/20 22:34, Michael S. Tsirkin wrote: On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to have missed: DMA to invalid memory addresses causes a crash in

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Fam Zheng
On Tue, 04/21 07:22, Michael S. Tsirkin wrote: On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: On Mon, 04/20 19:36, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: Currently, virtio code chooses to kill QEMU if the guest passes any

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: On Mon, 04/20 19:36, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Fam Zheng
On Mon, 04/20 19:36, Michael S. Tsirkin wrote: On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a very

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Cornelia Huck
On Fri, 17 Apr 2015 15:59:15 +0800 Fam Zheng f...@redhat.com wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a very long email), or possible denial of service in

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a very long email), or possible denial of service in a nested

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 19:36, Michael S. Tsirkin wrote: At the implementation level, there's one big issue you seem to have missed: DMA to invalid memory addresses causes a crash in memory core. I'm not sure whether it makes sense to recover from virtio core bugs when we can't recover from device

[Qemu-devel] [PATCH 00/18] virtio-blk: Support VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-17 Thread Fam Zheng
Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a very long email), or possible denial of service in a nested vm use case where virtio device is passed through. virtio-1