Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2019-01-04 Thread Richard Henderson
On 1/4/19 4:31 AM, Mark Cave-Ayland wrote: > Fixing the vsplt instruction now gives a readable display in my MacOS tests, > but I'm > still seeing "shadows" such as > https://www.ilande.co.uk/tmp/qemu/badapple4.png which > I've bisected down to: > > > commit 71f229eb331e979971a0a79e5a2fcdfb9380

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2019-01-03 Thread Mark Cave-Ayland
On 18/12/2018 06:38, Richard Henderson wrote: > This implements some of the things that I talked about with Mark > this morning / yesterday. In particular: > > (0) Implement expanders for nand, nor, eqv logical operations. > > (1) Implement saturating arithmetic for the tcg backend. > > Wh

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2019-01-03 Thread Mark Cave-Ayland
On 18/12/2018 09:49, Mark Cave-Ayland wrote: > Following on from this, the next patch "target/ppc: convert vsplt[bhw] to use > vector > operations" causes corruption of the OS X splash screen > (https://www.ilande.co.uk/tmp/qemu/badapple2.png) in a way that suggests > there may be > an endian is

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Richard Henderson
On 12/18/18 7:26 AM, Mark Cave-Ayland wrote: > That seems wrong to me. Given that the ppc_avr_t is a union then I'd expect > it to be > in host order? Certainly in the VMX helper macros I've looked at, the members > are set > directly with no byte swapping. "Host order"? For both words of the v

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Mark Cave-Ayland
On 18/12/2018 15:07, Richard Henderson wrote: >> This one appears to be a sign extension issue - if I make use of the same >> technique >> used by the previous helper then this problem goes away. Below is my >> experimental >> diff to be squashed into "target/ppc: convert vspltis[bhw] to use vec

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Mark Cave-Ayland
On 18/12/2018 15:17, Richard Henderson wrote: > On 12/18/18 7:05 AM, Mark Cave-Ayland wrote: >> On 18/12/2018 09:49, Mark Cave-Ayland wrote: >> >>> Following on from this, the next patch "target/ppc: convert vsplt[bhw] to >>> use vector >>> operations" causes corruption of the OS X splash screen

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Richard Henderson
On 12/18/18 6:51 AM, Mark Cave-Ayland wrote: > On 18/12/2018 09:49, Mark Cave-Ayland wrote: > >> A quick bisection suggests that there could be 2 separate issues related to >> the >> implementation of splat: >> >> Patch "target/ppc: convert vspltis[bhw] to use vector operations" causes a >> blac

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Mark Cave-Ayland
On 18/12/2018 09:49, Mark Cave-Ayland wrote: > A quick bisection suggests that there could be 2 separate issues related to > the > implementation of splat: > > Patch "target/ppc: convert vspltis[bhw] to use vector operations" causes a > black > border to appear around the OS X splash screen > (

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Richard Henderson
On 12/18/18 7:05 AM, Mark Cave-Ayland wrote: > On 18/12/2018 09:49, Mark Cave-Ayland wrote: > >> Following on from this, the next patch "target/ppc: convert vsplt[bhw] to >> use vector >> operations" causes corruption of the OS X splash screen >> (https://www.ilande.co.uk/tmp/qemu/badapple2.png)

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Mark Cave-Ayland
On 18/12/2018 09:49, Mark Cave-Ayland wrote: > Following on from this, the next patch "target/ppc: convert vsplt[bhw] to use > vector > operations" causes corruption of the OS X splash screen > (https://www.ilande.co.uk/tmp/qemu/badapple2.png) in a way that suggests > there may be > an endian is

Re: [Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-18 Thread Mark Cave-Ayland
On 18/12/2018 06:38, Richard Henderson wrote: > This implements some of the things that I talked about with Mark > this morning / yesterday. In particular: > > (0) Implement expanders for nand, nor, eqv logical operations. > > (1) Implement saturating arithmetic for the tcg backend. > > Wh

[Qemu-devel] [PATCH 00/34] tcg, target/ppc vector improvements

2018-12-17 Thread Richard Henderson
This implements some of the things that I talked about with Mark this morning / yesterday. In particular: (0) Implement expanders for nand, nor, eqv logical operations. (1) Implement saturating arithmetic for the tcg backend. While I had expanders for these, they always went to helpers.