Re: [Qemu-devel] [PATCH 00/59] RAMState + qdev

2017-04-20 Thread Juan Quintela
no-re...@patchew.org wrote: > Hi, > ERROR: do not initialise globals to 0 or NULL > #24: FILE: hw/core/qdev.c:42: > +bool qdev_hotplug = false; > > total: 1 errors, 0 warnings, 24 lines checked I am just removing one static here. This is maintainer preference. there are three bools together, but

Re: [Qemu-devel] [PATCH 00/59] RAMState + qdev

2017-04-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170419205923.8808-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH 00/59] RAMState + qdev === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PATCH 00/59] RAMState + qdev

2017-04-19 Thread Juan Quintela
Hi Hi This is just v3 rebased, with review-by, and the small changes suggested. I added the removal of hotmplug because they are already reviewed. I plan to send this as migration/next for when 2.0 open. - put all reviews - rebase - small changes on compression-switch - add all the hotplug re