Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table

2010-01-19 Thread Christoph Hellwig
On Mon, Jan 18, 2010 at 01:11:27PM +0100, Kevin Wolf wrote: Return the appropriate error value instead of always using EIO. Don't free the L1 table on errors, we still need it. Signed-off-by: Kevin Wolf kw...@redhat.com Looks good correct, but shouldn't we free the clusters for the new l1

Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table

2010-01-19 Thread Kevin Wolf
Am 19.01.2010 11:58, schrieb Christoph Hellwig: On Mon, Jan 18, 2010 at 01:11:27PM +0100, Kevin Wolf wrote: Return the appropriate error value instead of always using EIO. Don't free the L1 table on errors, we still need it. Signed-off-by: Kevin Wolf kw...@redhat.com Looks good correct,

[Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table

2010-01-18 Thread Kevin Wolf
Return the appropriate error value instead of always using EIO. Don't free the L1 table on errors, we still need it. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2-cluster.c