Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

2018-05-28 Thread Greg Kurz
On Sat, 26 May 2018 01:23:03 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer > > - Guard two Linux only headers. > - Define `ENOATTR` only if not only defined >(it's defined in system headers on Darwin). > > Signed-off-by: Keno Fischer > --- > fsdev/file-op-9p.h | 2 ++ > hw

Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

2018-05-26 Thread Keno Fischer
>>> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h >>> index 3fa062b..a13e729 100644 >>> --- a/fsdev/file-op-9p.h >>> +++ b/fsdev/file-op-9p.h >>> @@ -16,7 +16,9 @@ >>> >>> #include >>> #include >>> +#ifdef CONFIG_LINUX >> >> What about a less restrictive: >> >> #ifndef __APPLE__ > > In g

Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

2018-05-26 Thread Peter Maydell
On 26 May 2018 at 07:30, Philippe Mathieu-Daudé wrote: > Hi Keno, > > On 05/26/2018 02:23 AM, k...@juliacomputing.com wrote: >> From: Keno Fischer >> >> - Guard two Linux only headers. >> - Define `ENOATTR` only if not only defined >>(it's defined in system headers on Darwin). >> >> Signed-

Re: [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

2018-05-25 Thread Philippe Mathieu-Daudé
Hi Keno, On 05/26/2018 02:23 AM, k...@juliacomputing.com wrote: > From: Keno Fischer > > - Guard two Linux only headers. > - Define `ENOATTR` only if not only defined >(it's defined in system headers on Darwin). > > Signed-off-by: Keno Fischer > --- > fsdev/file-op-9p.h | 2 ++ > hw/9

[Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions

2018-05-25 Thread keno
From: Keno Fischer - Guard two Linux only headers. - Define `ENOATTR` only if not only defined (it's defined in system headers on Darwin). Signed-off-by: Keno Fischer --- fsdev/file-op-9p.h | 2 ++ hw/9pfs/9p-local.c | 2 ++ include/qemu/xattr.h | 4 +++- 3 files changed, 7 insertions