Re: [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs

2018-04-25 Thread Thomas Huth
On 20.04.2018 16:52, Peter Maydell wrote: > Currently the serial.c realize code has an explicit check that it is not > connected to a disconnected backend (ie one with a NULL chardev). > This isn't what we want -- you should be able to create a serial device > even if it isn't attached to anything.

Re: [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs

2018-04-20 Thread Philippe Mathieu-Daudé
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Currently the serial.c realize code has an explicit check that it is not > connected to a disconnected backend (ie one with a NULL chardev). > This isn't what we want -- you should be able to create a serial device > even if it isn't attached to anythi

[Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs

2018-04-20 Thread Peter Maydell
Currently the serial.c realize code has an explicit check that it is not connected to a disconnected backend (ie one with a NULL chardev). This isn't what we want -- you should be able to create a serial device even if it isn't attached to anything. Remove the check. Signed-off-by: Peter Maydell