Re: [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components

2016-02-22 Thread Paolo Bonzini
On 20/02/2016 01:19, Eric Blake wrote: > Commit d0d7708b forgot to parse logging for spice chardevs and > virtual consoles. This requires making qemu_chr_parse_common() > non-static. While at it, use a temporary variable to make the > code shorter, as well as reduce the churn when a later patch

Re: [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:31PM -0700, Eric Blake wrote: > Commit d0d7708b forgot to parse logging for spice chardevs and > virtual consoles. This requires making qemu_chr_parse_common() > non-static. While at it, use a temporary variable to make the > code shorter, as well as reduce the churn

[Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components

2016-02-19 Thread Eric Blake
Commit d0d7708b forgot to parse logging for spice chardevs and virtual consoles. This requires making qemu_chr_parse_common() non-static. While at it, use a temporary variable to make the code shorter, as well as reduce the churn when a later patch alters the layout of simple unions.