Re: [Qemu-devel] [PATCH 01/18] avoid dubiously clever code in win32_start_timer

2010-03-17 Thread Anthony Liguori
On 03/10/2010 04:38 AM, Paolo Bonzini wrote: The code is initializing an unsigned int to UINT_MAX using "-1", so that the following always-true comparison seems to be always-false at a first look. Since alarm timer initializations are never nested, it is simpler to unconditionally store the resu

[Qemu-devel] [PATCH 01/18] avoid dubiously clever code in win32_start_timer

2010-03-10 Thread Paolo Bonzini
The code is initializing an unsigned int to UINT_MAX using "-1", so that the following always-true comparison seems to be always-false at a first look. Since alarm timer initializations are never nested, it is simpler to unconditionally store the result of timeGetDevCaps into data->period. Signed