Il 17/10/2012 14:56, Markus Armbruster ha scritto:
> Duplicates error_set() code without need. How about:
>
> void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
> const char *fmt, ...)
> {
> char *msg;
>
> va_start(ap, fmt);
> msg = g_strdup_p
Paolo Bonzini writes:
> These functions help maintaining homogeneous formatting of error
> messages that include strerror values.
>
> Signed-off-by: Paolo Bonzini
> ---
> error.c | 28
> error.h | 9 +
> 2 file modificati, 37 inserzioni(+)
>
> diff --git a/
Luiz Capitulino writes:
> On Thu, 04 Oct 2012 18:16:13 +0200
> Paolo Bonzini wrote:
>
>> Il 04/10/2012 18:14, Luiz Capitulino ha scritto:
>> >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
>> >> > + const char *fmt, ...)
>> >
>> > The function's
On Thu, 04 Oct 2012 18:16:13 +0200
Paolo Bonzini wrote:
> Il 04/10/2012 18:14, Luiz Capitulino ha scritto:
> >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
> >> > + const char *fmt, ...)
> >
> > The function's name makes me expect that something
Il 04/10/2012 18:14, Luiz Capitulino ha scritto:
>> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
>> > + const char *fmt, ...)
>
> The function's name makes me expect that something else is done with os_errno
On Wed, 3 Oct 2012 16:36:48 +0200
Paolo Bonzini wrote:
> These functions help maintaining homogeneous formatting of error
> messages that include strerror values.
>
> Signed-off-by: Paolo Bonzini
Acked-by: Luiz Capitulino
One small comment below.
> ---
> error.c | 28 +
These functions help maintaining homogeneous formatting of error
messages that include strerror values.
Signed-off-by: Paolo Bonzini
---
error.c | 28
error.h | 9 +
2 file modificati, 37 inserzioni(+)
diff --git a/error.c b/error.c
index 1f05fc4..128d88c 1
