Re: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > Before this patch, if sosendto fails, udp_input is executed as if the > packet was sent, recording the packet for icmp errors, which does not > makes sense since the packet was not actually sent, errors

Re: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

Thomas Huth, on Fri 11 Dec 2015 12:54:14 +0100, wrote: > > @@ -5,7 +5,7 @@ > > * terms and conditions of the copyright. > > */ > > > > -//#define DEBUG 1 > > +#define DEBUG 1 > > Please don't enable the debug code by default. Oops, sorry, that wasn't meant to be included in the patch

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

From: Guillaume Subiron Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this

Re: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

On 07/29/2015 06:57 AM, Samuel Thibault wrote: Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron maet...@subiron.org --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff