Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2017 17:56, Vladimir Sementsov-Ogievskiy wrote: 31.05.2017 17:39, Eric Blake wrote: On 05/31/2017 08:12 AM, Vladimir Sementsov-Ogievskiy wrote: 30.05.2017 23:10, Eric Blake wrote: On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: Functions nbd_negotiate_{read,write,drop_sync}

Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2017 17:39, Eric Blake wrote: On 05/31/2017 08:12 AM, Vladimir Sementsov-Ogievskiy wrote: 30.05.2017 23:10, Eric Blake wrote: On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: Functions nbd_negotiate_{read,write,drop_sync} were introduced in 1a6245a5b, when nbd_wr_syncv was

Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-31 Thread Eric Blake
On 05/31/2017 08:12 AM, Vladimir Sementsov-Ogievskiy wrote: > 30.05.2017 23:10, Eric Blake wrote: >> On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Functions nbd_negotiate_{read,write,drop_sync} were introduced in >>> 1a6245a5b, when nbd_wr_syncv was working through

Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-31 Thread Vladimir Sementsov-Ogievskiy
30.05.2017 23:10, Eric Blake wrote: On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: Functions nbd_negotiate_{read,write,drop_sync} were introduced in 1a6245a5b, when nbd_wr_syncv was working through qemu_co_sendv_recvv, There is no qemu_co_sendv_recvv. Did you mean

Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Functions nbd_negotiate_{read,write,drop_sync} were introduced in > 1a6245a5b, when nbd_wr_syncv was working through qemu_co_sendv_recvv, There is no qemu_co_sendv_recvv. Did you mean qemu_co_recv/qemu_co_send? > which just yields,

[Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Functions nbd_negotiate_{read,write,drop_sync} were introduced in 1a6245a5b, when nbd_wr_syncv was working through qemu_co_sendv_recvv, which just yields, without setting any handlers. But now, nbd_wr_syncv works through qio_channel_yield() which sets handlers, so watchers are redundant in