Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-25 Thread Peter Maydell
On 17 September 2014 16:22, Richard Henderson wrote: > On 09/17/2014 04:54 AM, Andreas Färber wrote: >> I am fine with adding such hooks, but please let's use a better, active >> name. CPUClass is the struct name and cpu-exec is a file name; the hook >> should say what it's doing, not where the co

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Richard Henderson
On 09/17/2014 04:54 AM, Andreas Färber wrote: > I am fine with adding such hooks, but please let's use a better, active > name. CPUClass is the struct name and cpu-exec is a file name; the hook > should say what it's doing, not where the code (used to) live(s). Just > exec_enter/exec_exit possibly?

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Andreas Färber
Am 13.09.2014 um 18:45 schrieb Richard Henderson: > In preparation for removing a bunch of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 ++--- > include/qom/cpu.h | 5 + > qom/cpu.c | 6 -- > 3 files changed, 1

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > In preparation for removing a bunch of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 ++--- > include/qom/cpu.h | 5 + > qom/cpu.c | 6 -- > 3 files changed, 11 insertions(+), 9 dele

[Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-13 Thread Richard Henderson
In preparation for removing a bunch of ifdefs from cpu_exec. Cc: Andreas Färber Signed-off-by: Richard Henderson --- cpu-exec.c| 9 ++--- include/qom/cpu.h | 5 + qom/cpu.c | 6 -- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.