Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-19 Thread Alexander Graf
On 19.09.2012, at 16:34, Richard Henderson wrote: > On 09/19/2012 06:02 AM, Alexander Graf wrote: >> Richard, please double-check all the ilc passing again with the spec. > > I'll look again. > > But I do recall that the spec is consistent in placing a 3-bit field (values > 1-3) > shifted one

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-19 Thread Richard Henderson
On 09/19/2012 06:02 AM, Alexander Graf wrote: > Richard, please double-check all the ilc passing again with the spec. I'll look again. But I do recall that the spec is consistent in placing a 3-bit field (values 1-3) shifted one bit left into the larger 32-bit field, so that in essence the value

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-19 Thread Alexander Graf
On 19.09.2012, at 13:34, Alexander Graf wrote: > > On 19.09.2012, at 13:29, Peter Maydell wrote: > >> On 19 September 2012 01:14, Richard Henderson wrote: >>> On 09/18/2012 01:18 PM, Alexander Graf wrote: > -/* remember what pgm exeption this was */ > +/* Remember what pgm exep

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-19 Thread Alexander Graf
On 19.09.2012, at 13:29, Peter Maydell wrote: > On 19 September 2012 01:14, Richard Henderson wrote: >> On 09/18/2012 01:18 PM, Alexander Graf wrote: -/* remember what pgm exeption this was */ +/* Remember what pgm exeption this was. */ > > ...if you're changing this comment

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-19 Thread Peter Maydell
On 19 September 2012 01:14, Richard Henderson wrote: > On 09/18/2012 01:18 PM, Alexander Graf wrote: >>> -/* remember what pgm exeption this was */ >>> +/* Remember what pgm exeption this was. */ ...if you're changing this comment then at least fix the typo ("exception")... >>> tm

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-19 Thread Alexander Graf
On 19.09.2012, at 02:14, Richard Henderson wrote: > On 09/18/2012 01:18 PM, Alexander Graf wrote: >>> -/* remember what pgm exeption this was */ >>> +/* Remember what pgm exeption this was. */ >>> tmp = tcg_const_i32(code); >>> tcg_gen_st_i32(tmp, cpu_env, offsetof(CPUS390XStat

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-18 Thread Richard Henderson
On 09/18/2012 01:18 PM, Alexander Graf wrote: >> -/* remember what pgm exeption this was */ >> +/* Remember what pgm exeption this was. */ >> tmp = tcg_const_i32(code); >> tcg_gen_st_i32(tmp, cpu_env, offsetof(CPUS390XState, int_pgm_code)); >> tcg_temp_free_i32(tmp); >>

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-18 Thread Alexander Graf
On 09/09/2012 11:04 PM, Richard Henderson wrote: Make the user path more like the system path. Prepare for more kinds of runtime exceptions. Compute ILC from S->NEXT_PC, rather than passing it around. Signed-off-by: Richard Henderson --- linux-user/main.c | 133 +---

[Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

2012-09-09 Thread Richard Henderson
Make the user path more like the system path. Prepare for more kinds of runtime exceptions. Compute ILC from S->NEXT_PC, rather than passing it around. Signed-off-by: Richard Henderson --- linux-user/main.c | 133 +-- target-s390x/cpu.h | 11 --- targe