Re: [Qemu-devel] [PATCH 02/10] ppc/xive: introduce a XiveTCTX pointer under PowerPCCPU

2019-01-04 Thread David Gibson
On Thu, Jan 03, 2019 at 06:44:30PM +0100, Cédric Le Goater wrote: > On 1/3/19 4:57 AM, David Gibson wrote: > > On Wed, Jan 02, 2019 at 06:57:35AM +0100, Cédric Le Goater wrote: > >> which will be used by the machine only when the XIVE interrupt mode is > >> in use. > > > > I don't love the idea of

Re: [Qemu-devel] [PATCH 02/10] ppc/xive: introduce a XiveTCTX pointer under PowerPCCPU

2019-01-03 Thread Cédric Le Goater
On 1/3/19 4:57 AM, David Gibson wrote: > On Wed, Jan 02, 2019 at 06:57:35AM +0100, Cédric Le Goater wrote: >> which will be used by the machine only when the XIVE interrupt mode is >> in use. > > I don't love the idea of putting a hook this specific into the > PowerPCCPU structure, though it might

Re: [Qemu-devel] [PATCH 02/10] ppc/xive: introduce a XiveTCTX pointer under PowerPCCPU

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:35AM +0100, Cédric Le Goater wrote: > which will be used by the machine only when the XIVE interrupt mode is > in use. I don't love the idea of putting a hook this specific into the PowerPCCPU structure, though it might be the easiest path in the short term. A couple

[Qemu-devel] [PATCH 02/10] ppc/xive: introduce a XiveTCTX pointer under PowerPCCPU

2019-01-01 Thread Cédric Le Goater
which will be used by the machine only when the XIVE interrupt mode is in use. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h| 2 ++ hw/intc/xive.c | 6 +++--- hw/ppc/spapr_cpu_core.c | 7 ++- hw/ppc/spapr_irq.c | 8 4 files changed, 15 insertions(+), 8 d