Il 07/07/2012 09:48, Blue Swirl ha scritto:
>> > I do plan to fix the clarity issue with SCSI data structures and
>> > constants. But for now, the best compromise is to keep C++ comments
>> > IMHO. I'm not pushing the responsibility to other people in general,
>> > but if they think C++ comments
On Fri, Jul 6, 2012 at 7:05 AM, Paolo Bonzini wrote:
> Il 05/07/2012 20:03, Blue Swirl ha scritto:
>> > > > +if (s->wwn) {
>> > > > +outbuf[buflen++] = 0x1; // Binary
>> > > > +outbuf[buflen++] = 0x3; // NAA
>> > > > +outbuf[buflen++] = 0
Il 05/07/2012 20:03, Blue Swirl ha scritto:
> > > > +if (s->wwn) {
> > > > +outbuf[buflen++] = 0x1; // Binary
> > > > +outbuf[buflen++] = 0x3; // NAA
> > > > +outbuf[buflen++] = 0; // reserved
> > >
> > > C99 comments.
> >
> > Just follo
On Wed, Jul 4, 2012 at 7:33 AM, Paolo Bonzini wrote:
> Il 03/07/2012 21:09, Blue Swirl ha scritto:
>>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest
>>> > *req, uint8_t *outbuf)
>>> > outbuf[buflen++] = 0; // not officially assigned
>>> > outb
Il 03/07/2012 21:09, Blue Swirl ha scritto:
>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest
>> > *req, uint8_t *outbuf)
>> > outbuf[buflen++] = 0; // not officially assigned
>> > outbuf[buflen++] = 0; // reserved
>> > outbuf[buf
On Mon, Jul 2, 2012 at 9:41 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hw/scsi-disk.c | 14 +-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index 747e756..e87e57c 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/s
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 747e756..e87e57c 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -67,6 +67,7 @@ struct SCSIDiskState
bool media_chang
