Re: [Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h

2018-07-05 Thread David Gibson
On Thu, Jul 05, 2018 at 11:19:49AM -0700, Michael Davidsaver wrote: > Use names for registers and bits except > for R_CTRL which will be dealt with later, > and isn't modeled anyway. > > Signed-off-by: Michael Davidsaver > Reviewed-by: Peter Maydell Reviewed-by: David Gibson > --- > hw/timer

[Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h

2018-07-05 Thread Michael Davidsaver
Use names for registers and bits except for R_CTRL which will be dealt with later, and isn't modeled anyway. Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell --- hw/timer/ds1338.c | 80 +-- 1 file changed, 54 insertions(+), 26 dele

Re: [Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h

2018-04-12 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Use names for registers and bits except > for R_CTRL which will be dealt with later, > and isn't modeled anyway. > > Signed-off-by: Michael Davidsaver > --- > hw/timer/ds1338.c | 84 > ++-

[Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h

2018-03-24 Thread Michael Davidsaver
Use names for registers and bits except for R_CTRL which will be dealt with later, and isn't modeled anyway. Signed-off-by: Michael Davidsaver --- hw/timer/ds1338.c | 84 ++- 1 file changed, 58 insertions(+), 26 deletions(-) diff --git a/hw/ti